Improve descriptions of notation #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This belongs in chapter 'Lexical Structure'.
Makes the introducing easier to digest, and places explanation where one would expect it.
These exceptions are just confusing as the grammar actually allows both 'der' and 'initial' (and also 'pure') to be used as the callee of a function call expression.
According to decreasing order of importance for readers.
In the introduction, it's better to just focus on notation.
eshmoylova
requested changes
Nov 23, 2021
|
Looks good, except for the minor issues noted above. |
eshmoylova
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
I like the new look of the Notation section. I noticed one multi-line sentence but it was there before, so it's "if you want to fix now" and it is not required for this PR.
One other thing, which is not part of this PR but something that we discussed in #3034 is how Modelica comments are rendered in PDF. I noticed that when I view the pdf in a browser at 100% zoom some words appear much smaller, e.g. "represented" in the last comment.
If I zoom in they look the same size. Just thought I'd mention it in case we need more examples for #3034 (comment)
HansOlsson
reviewed
Nov 30, 2021
HansOlsson
reviewed
Nov 30, 2021
HansOlsson
requested changes
Nov 30, 2021
Addressing commend by Hans.
As suggested by Hans. Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>
Saying we 'do' invalid code sounded a bit too informal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3044.